lsm/seaweedfs
1
0
Fork 0
mirror of https://github.com/seaweedfs/seaweedfs.git synced 2025-09-23 16:33:35 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

change comment for expect header (#6289)

Browse Source 
* remove case of expect

* Set the default value of the Expect header for compatibility.
This commit is contained in:
steve.wei
2024-11-27 00:35:41 +08:00
committed by GitHub
parent e2e97db917
commit 88fa64a01a
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
weed/s3api/auth_signature_v4.go
View File

@@ -666,9 +666,10 @@ func extractSignedHeaders(signedHeaders []string, r *http.Request) (http.Header,
} }
switch header { switch header {
case "expect": case "expect":
// Golang http server strips off 'Expect' header, if the // Set the default value of the Expect header for compatibility.
// client sent this as part of signed headers we need to //
// handle otherwise we would see a signature mismatch. // In NGINX v1.1, the Expect header is removed when handling 100-continue requests.
//
// `aws-cli` sets this as part of signed headers. // `aws-cli` sets this as part of signed headers.
// //
// According to // According to
@@ -680,8 +681,6 @@ func extractSignedHeaders(signedHeaders []string, r *http.Request) (http.Header,
// //
// So it safe to assume that '100-continue' is what would // So it safe to assume that '100-continue' is what would
// be sent, for the time being keep this work around. // be sent, for the time being keep this work around.
// Adding a *TODO* to remove this later when Golang server
// doesn't filter out the 'Expect' header.
extractedSignedHeaders.Set(header, "100-continue") extractedSignedHeaders.Set(header, "100-continue")
case "host": case "host":
// Go http server removes "host" from Request.Header // Go http server removes "host" from Request.Header