lsm/seaweedfs
1
0
Fork 0
mirror of https://github.com/seaweedfs/seaweedfs.git synced 2025-11-24 16:53:14 +08:00
Code Issues Actions 17 Packages Projects Releases Wiki Activity

adjust comments

Browse Source
This commit is contained in:
chrislu
2025-08-13 00:34:41 -07:00
parent 117bba794c
commit b616dc3d20
2 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
weed/storage/erasure_coding/ec_decoder.go
View File

@@ -215,6 +215,7 @@ func min(x, y int64) int64 {
// WriteDatFileAndVacuum reconstructs volume from EC shards and then vacuums deleted needles // WriteDatFileAndVacuum reconstructs volume from EC shards and then vacuums deleted needles
// This reuses existing WriteDatFile and volume compaction logic to achieve the same result more cleanly // This reuses existing WriteDatFile and volume compaction logic to achieve the same result more cleanly
// Creates cleaned volume files (without generation) that are ready for generational EC encoding
func WriteDatFileAndVacuum(baseFileName string, shardFileNames []string) error { func WriteDatFileAndVacuum(baseFileName string, shardFileNames []string) error {
// Step 1: Use existing WriteDatFile to reconstruct the full volume // Step 1: Use existing WriteDatFile to reconstruct the full volume
datFileSize, err := FindDatFileSize(baseFileName, baseFileName) datFileSize, err := FindDatFileSize(baseFileName, baseFileName)
@@ -243,9 +244,11 @@ func WriteDatFileAndVacuum(baseFileName string, shardFileNames []string) error {
return fmt.Errorf("failed to read volume version: %w", err) return fmt.Errorf("failed to read volume version: %w", err)
} }
// Create cleaned volume files (without generation suffix)
// These will later be copied to generation-aware names by encodeVolumeToEcShards()
return copyDataBasedOnIndexFileForEcVacuum( return copyDataBasedOnIndexFileForEcVacuum(
tempDatFile, tempIdxFile, // source files (with deleted entries) tempDatFile, tempIdxFile, // source files (with deleted entries)
baseFileName+".dat", baseFileName+".idx", // destination files (cleaned) baseFileName+".dat", baseFileName+".idx", // destination files (cleaned, ready for generational encoding)
version, version,
) )
} }

5
weed/worker/tasks/ec_vacuum/ec_vacuum_task.go
View File

@@ -403,12 +403,13 @@ func (t *EcVacuumTask) decodeEcShardsToVolume() error {
return fmt.Errorf("failed to reconstruct and vacuum volume: %w", err) return fmt.Errorf("failed to reconstruct and vacuum volume: %w", err)
} }
t.LogInfo("Successfully decoded EC shards to filtered normal volume", map[string]interface{}{ t.LogInfo("Successfully decoded EC shards to cleaned volume", map[string]interface{}{
"dat_file": datFileName, "dat_file": datFileName,
"idx_file": idxFileName, "idx_file": idxFileName,
"original_dat_size": datFileSize, "original_dat_size": datFileSize,
"deleted_entries_filtered": true, "deleted_entries_filtered": true,
"note": "deleted needles physically removed from volume", "note": "cleaned volume ready for generational EC encoding",
"next_step": "will create generation-aware EC shards",
}) })
return nil return nil