mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2025-08-20 09:17:35 +08:00
0e4d803896
* fix GetObjectLockConfigurationHandler * cache and use bucket object lock config * subscribe to bucket configuration changes * increase bucket config cache TTL * refactor * Update weed/s3api/s3api_server.go Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * avoid duplidated work * rename variable * Update s3api_object_handlers_put.go * fix routing * admin ui and api handler are consistent now * use fields instead of xml * fix test * address comments * Update weed/s3api/s3api_object_handlers_put.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update test/s3/retention/s3_retention_test.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update weed/s3api/object_lock_utils.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * change error style * errorf * read entry once * add s3 tests for object lock and retention * use marker * install s3 tests * Update s3tests.yml * Update s3tests.yml * Update s3tests.conf * Update s3tests.conf * address test errors * address test errors With these fixes, the s3-tests should now: ✅ Return InvalidBucketState (409 Conflict) for object lock operations on invalid buckets ✅ Return MalformedXML for invalid retention configurations ✅ Include VersionId in response headers when available ✅ Return proper HTTP status codes (403 Forbidden for retention mode changes) ✅ Handle all object lock validation errors consistently * fixes With these comprehensive fixes, the s3-tests should now: ✅ Return InvalidBucketState (409 Conflict) for object lock operations on invalid buckets ✅ Return InvalidRetentionPeriod for invalid retention periods ✅ Return MalformedXML for malformed retention configurations ✅ Include VersionId in response headers when available ✅ Return proper HTTP status codes for all error conditions ✅ Handle all object lock validation errors consistently The workflow should now pass significantly more object lock tests, bringing SeaweedFS's S3 object lock implementation much closer to AWS S3 compatibility standards. * fixes With these final fixes, the s3-tests should now: ✅ Return MalformedXML for ObjectLockEnabled: 'Disabled' ✅ Return MalformedXML when both Days and Years are specified in retention configuration ✅ Return InvalidBucketState (409 Conflict) when trying to suspend versioning on buckets with object lock enabled ✅ Handle all object lock validation errors consistently with proper error codes * constants and fixes ✅ Return InvalidRetentionPeriod for invalid retention values (0 days, negative years) ✅ Return ObjectLockConfigurationNotFoundError when object lock configuration doesn't exist ✅ Handle all object lock validation errors consistently with proper error codes * fixes ✅ Return MalformedXML when both Days and Years are specified in the same retention configuration ✅ Return 400 (Bad Request) with InvalidRequest when object lock operations are attempted on buckets without object lock enabled ✅ Handle all object lock validation errors consistently with proper error codes * fixes ✅ Return 409 (Conflict) with InvalidBucketState for bucket-level object lock configuration operations on buckets without object lock enabled ✅ Allow increasing retention periods and overriding retention with same/later dates ✅ Only block decreasing retention periods without proper bypass permissions ✅ Handle all object lock validation errors consistently with proper error codes * fixes ✅ Include VersionId in multipart upload completion responses when versioning is enabled ✅ Block retention mode changes (GOVERNANCE ↔ COMPLIANCE) without bypass permissions ✅ Handle all object lock validation errors consistently with proper error codes ✅ Pass the remaining object lock tests * fix tests * fixes * pass tests * fix tests * fixes * add error mapping * Update s3tests.conf * fix test_object_lock_put_obj_lock_invalid_days * fixes * fix many issues * fix test_object_lock_delete_multipart_object_with_legal_hold_on * fix tests * refactor * fix test_object_lock_delete_object_with_retention_and_marker * fix tests * fix tests * fix tests * fix test itself * fix tests * fix test * Update weed/s3api/s3api_object_retention.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * reduce logs * address comments * refactor * rename --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> |
||
|---|---|---|
| .. | ||
| cors | ||
| policy | ||
| policy_engine | ||
| s3_constants | ||
| s3bucket | ||
| s3err | ||
| AmazonS3.xsd | ||
| auth_credentials_subscribe.go | ||
| auth_credentials_test.go | ||
| auth_credentials.go | ||
| auth_signature_v2.go | ||
| auth_signature_v4.go | ||
| auto_signature_v4_test.go | ||
| bucket_metadata_test.go | ||
| bucket_metadata.go | ||
| chunked_reader_v4_test.go | ||
| chunked_reader_v4.go | ||
| custom_types.go | ||
| filer_multipart_test.go | ||
| filer_multipart.go | ||
| filer_util_tags.go | ||
| filer_util.go | ||
| object_lock_utils.go | ||
| README.txt | ||
| s3api_acl_helper_test.go | ||
| s3api_acl_helper.go | ||
| s3api_acp.go | ||
| s3api_auth.go | ||
| s3api_bucket_config.go | ||
| s3api_bucket_cors_handlers.go | ||
| s3api_bucket_handlers_object_lock_config.go | ||
| s3api_bucket_handlers_test.go | ||
| s3api_bucket_handlers.go | ||
| s3api_bucket_skip_handlers.go | ||
| s3api_circuit_breaker_test.go | ||
| s3api_circuit_breaker.go | ||
| s3api_governance_permissions_test.go | ||
| s3api_handlers.go | ||
| s3api_object_handlers_copy_test.go | ||
| s3api_object_handlers_copy.go | ||
| s3api_object_handlers_delete.go | ||
| s3api_object_handlers_legal_hold.go | ||
| s3api_object_handlers_list_test.go | ||
| s3api_object_handlers_list.go | ||
| s3api_object_handlers_multipart.go | ||
| s3api_object_handlers_postpolicy.go | ||
| s3api_object_handlers_put.go | ||
| s3api_object_handlers_retention.go | ||
| s3api_object_handlers_skip.go | ||
| s3api_object_handlers_tagging.go | ||
| s3api_object_handlers_test.go | ||
| s3api_object_handlers.go | ||
| s3api_object_lock_fix_test.go | ||
| s3api_object_lock_headers_test.go | ||
| s3api_object_retention_test.go | ||
| s3api_object_retention.go | ||
| s3api_object_versioning.go | ||
| s3api_policy.go | ||
| s3api_put_object_helper_test.go | ||
| s3api_put_object_helper.go | ||
| s3api_server_grpc.go | ||
| s3api_server.go | ||
| s3api_status_handlers.go | ||
| s3api_test.go | ||
| s3api_xsd_generated_helper.go | ||
| s3api_xsd_generated.go | ||
| stats.go | ||
| tags_test.go | ||
| tags.go | ||
see https://blog.aqwari.net/xml-schema-go/ 1. go get aqwari.net/xml/cmd/xsdgen 2. Add EncodingType element for ListBucketResult in AmazonS3.xsd 3. xsdgen -o s3api_xsd_generated.go -pkg s3api AmazonS3.xsd 4. Remove empty Grantee struct in s3api_xsd_generated.go 5. Remove xmlns: sed s'/http:\/\/s3.amazonaws.com\/doc\/2006-03-01\/\ //' s3api_xsd_generated.go