seaweedfs/weed
Chris Lu 0ecb466eda
Admin: refactoring active topology (#7073)
* refactoring

* add ec shard size

* address comments

* passing task id

There seems to be a disconnect between the pending tasks created in ActiveTopology and the TaskDetectionResult returned by this function. A taskID is generated locally and used to create pending tasks via AddPendingECShardTask, but this taskID is not stored in the TaskDetectionResult or passed along in any way.

This makes it impossible for the worker that eventually executes the task to know which pending task in ActiveTopology it corresponds to. Without the correct taskID, the worker cannot call AssignTask or CompleteTask on the master, breaking the entire task lifecycle and capacity management feature.

A potential solution is to add a TaskID field to TaskDetectionResult and worker_pb.TaskParams, ensuring the ID is propagated from detection to execution.

* 1 source multiple destinations

* task supports multi source and destination

* ec needs to clean up previous shards

* use erasure coding constants

* getPlanningCapacityUnsafe getEffectiveAvailableCapacityUnsafe  should return StorageSlotChange for calculation

* use CanAccommodate to calculate

* remove dead code

* address comments

* fix Mutex Copying in Protobuf Structs

* use constants

* fix estimatedSize

The calculation for estimatedSize only considers source.EstimatedSize and dest.StorageChange, but omits dest.EstimatedSize. The TaskDestination struct has an EstimatedSize field, which seems to be ignored here. This could lead to an incorrect estimation of the total size of data involved in tasks on a disk. The loop should probably also include estimatedSize += dest.EstimatedSize.

* at.assignTaskToDisk(task)

* refactoring

* Update weed/admin/topology/internal.go

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* fail fast

* fix compilation

* Update weed/worker/tasks/erasure_coding/detection.go

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* indexes for volume and shard locations

* dedup with ToVolumeSlots

* return an additional boolean to indicate success, or an error

* Update abstract_sql_store.go

* fix

* Update weed/worker/tasks/erasure_coding/detection.go

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* Update weed/admin/topology/task_management.go

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* faster findVolumeDisk

* Update weed/worker/tasks/erasure_coding/detection.go

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update weed/admin/topology/storage_slot_test.go

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* refactor

* simplify

* remove unused GetDiskStorageImpact function

* refactor

* add comments

* Update weed/admin/topology/storage_impact.go

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* Update weed/admin/topology/storage_slot_test.go

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* Update storage_impact.go

* AddPendingTask

The unified AddPendingTask function now serves as the single entry point for all task creation, successfully consolidating the previously separate functions while maintaining full functionality and improving code organization.

---------

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2025-08-03 01:35:38 -07:00
..
admin Admin: refactoring active topology (#7073) 2025-08-03 01:35:38 -07:00
cluster add CORS tests (#7001) 2025-07-19 23:56:17 -07:00
command Admin: misc improvements on admin server and workers. EC now works. (#7055) 2025-07-30 12:38:03 -07:00
credential convert error fromating to %w everywhere (#6995) 2025-07-16 23:39:27 -07:00
filer Admin: refactoring active topology (#7073) 2025-08-03 01:35:38 -07:00
filer_client Admin UI: Add message queue to admin UI (#6958) 2025-07-11 10:19:27 -07:00
glog convert error fromating to %w everywhere (#6995) 2025-07-16 23:39:27 -07:00
iamapi convert error fromating to %w everywhere (#6995) 2025-07-16 23:39:27 -07:00
images Migrates from disintegration/imaging c2019 to cognusion/imaging c2024. (#5533) 2024-04-24 23:16:04 -07:00
mount convert error fromating to %w everywhere (#6995) 2025-07-16 23:39:27 -07:00
mq convert error fromating to %w everywhere (#6995) 2025-07-16 23:39:27 -07:00
notification fix: dead letter message log message (#7072) 2025-08-02 08:21:57 -07:00
operation convert error fromating to %w everywhere (#6995) 2025-07-16 23:39:27 -07:00
pb Admin: refactoring active topology (#7073) 2025-08-03 01:35:38 -07:00
query move to https://github.com/seaweedfs/seaweedfs 2022-07-29 00:17:28 -07:00
remote_storage convert error fromating to %w everywhere (#6995) 2025-07-16 23:39:27 -07:00
replication convert error fromating to %w everywhere (#6995) 2025-07-16 23:39:27 -07:00
s3api Support X-Forwarded-Port (#7070) 2025-08-01 15:45:34 -07:00
security [security] reload whiteList on http seerver (#6302) 2024-12-02 10:38:10 -08:00
sequence remove unused function 2024-06-25 09:18:11 -07:00
server fix parsing s3 tag (#7069) 2025-08-01 15:45:23 -07:00
sftpd convert error fromating to %w everywhere (#6995) 2025-07-16 23:39:27 -07:00
shell Admin UI: include ec shard sizes into volume server info (#7071) 2025-08-02 02:16:49 -07:00
static Fix Broken Links (#5287) 2024-02-14 08:26:38 -08:00
stats [volume] refactor and add metrics for flight upload and download data limit condition (#6920) 2025-07-02 18:03:49 -07:00
storage Admin UI: include ec shard sizes into volume server info (#7071) 2025-08-02 02:16:49 -07:00
telemetry convert error fromating to %w everywhere (#6995) 2025-07-16 23:39:27 -07:00
topology Admin UI: include ec shard sizes into volume server info (#7071) 2025-08-02 02:16:49 -07:00
util 3.96 2025-07-31 22:46:51 -07:00
wdclient convert error fromating to %w everywhere (#6995) 2025-07-16 23:39:27 -07:00
worker Admin: refactoring active topology (#7073) 2025-08-03 01:35:38 -07:00
Makefile test versioning also (#7000) 2025-07-19 21:43:34 -07:00
weed.go set exit status 2025-03-17 23:13:27 -07:00