From 98881f2e766bf275189ef73f50731799d73a934b Mon Sep 17 00:00:00 2001
From: playersun <playersun@users.noreply.github.com>
Date: Wed, 11 Oct 2023 00:18:57 +0800
Subject: [PATCH] =?UTF-8?q?:art:=20=E4=BB=A3=E7=A0=81=E4=BC=98=E5=8C=96?=
 =?UTF-8?q?=EF=BC=8C=E9=98=B2=E6=AD=A2=E5=87=BA=E7=8E=B0=E7=A9=BA=E6=8C=87?=
 =?UTF-8?q?=E9=92=88=E5=BC=82=E5=B8=B8=E6=8A=A5=E9=94=99?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Co-authored-by: sunhui <10151317@qq.com>
---
 .../wx/miniapp/api/impl/BaseWxMaServiceImpl.java    | 13 +++++++++++--
 .../weixin/mp/api/impl/BaseWxMpServiceImpl.java     | 13 +++++++++++--
 2 files changed, 22 insertions(+), 4 deletions(-)

diff --git a/weixin-java-miniapp/src/main/java/cn/binarywang/wx/miniapp/api/impl/BaseWxMaServiceImpl.java b/weixin-java-miniapp/src/main/java/cn/binarywang/wx/miniapp/api/impl/BaseWxMaServiceImpl.java
index 0c9aa9d62..37a25db14 100644
--- a/weixin-java-miniapp/src/main/java/cn/binarywang/wx/miniapp/api/impl/BaseWxMaServiceImpl.java
+++ b/weixin-java-miniapp/src/main/java/cn/binarywang/wx/miniapp/api/impl/BaseWxMaServiceImpl.java
@@ -377,7 +377,12 @@ public abstract class BaseWxMaServiceImpl<H, P> implements WxMaService, RequestH
   @Override
   @JsonDeserialize
   public void setMultiConfigs(Map<String, WxMaConfig> configs, String defaultMiniappId) {
-    this.configMap = Maps.newHashMap(configs);
+    // 防止覆盖配置
+    if(this.configMap != null) {
+      this.configMap.putAll(configs);
+    } else {
+      this.configMap = Maps.newHashMap(configs);
+    }
     WxMaConfigHolder.set(defaultMiniappId);
     this.initHttp();
   }
@@ -385,7 +390,11 @@ public abstract class BaseWxMaServiceImpl<H, P> implements WxMaService, RequestH
   @Override
   public void addConfig(String miniappId, WxMaConfig configStorages) {
     synchronized (this) {
-      if (this.configMap == null) {
+      /*
+       * 因为commit f74b00cf 默认初始化了configMap，导致使用此方法无法进入if从而触发initHttp()，
+       * 就会出现HttpClient报NullPointException
+       */
+      if (this.configMap == null || this.configMap.isEmpty()) {
         this.setWxMaConfig(configStorages);
       } else {
         WxMaConfigHolder.set(miniappId);
diff --git a/weixin-java-mp/src/main/java/me/chanjar/weixin/mp/api/impl/BaseWxMpServiceImpl.java b/weixin-java-mp/src/main/java/me/chanjar/weixin/mp/api/impl/BaseWxMpServiceImpl.java
index cb2479c57..d7c0f53ab 100644
--- a/weixin-java-mp/src/main/java/me/chanjar/weixin/mp/api/impl/BaseWxMpServiceImpl.java
+++ b/weixin-java-mp/src/main/java/me/chanjar/weixin/mp/api/impl/BaseWxMpServiceImpl.java
@@ -542,7 +542,12 @@ public abstract class BaseWxMpServiceImpl<H, P> implements WxMpService, RequestH
 
   @Override
   public void setMultiConfigStorages(Map<String, WxMpConfigStorage> configStorages, String defaultMpId) {
-    this.configStorageMap = Maps.newHashMap(configStorages);
+    // 防止覆盖配置
+    if(this.configStorageMap != null) {
+      this.configStorageMap.putAll(configStorages);
+    } else {
+      this.configStorageMap = Maps.newHashMap(configStorages);
+    }
     WxMpConfigStorageHolder.set(defaultMpId);
     this.initHttp();
   }
@@ -550,7 +555,11 @@ public abstract class BaseWxMpServiceImpl<H, P> implements WxMpService, RequestH
   @Override
   public void addConfigStorage(String mpId, WxMpConfigStorage configStorages) {
     synchronized (this) {
-      if (this.configStorageMap == null) {
+      /*
+       * 因为commit 2aa27cf12d 默认初始化了configStorageMap，导致使用此方法无法进入if从而触发initHttp()，
+       * 就会出现HttpClient报NullPointException
+       */
+      if (this.configStorageMap == null || this.configStorageMap.isEmpty()) {
         this.setWxMpConfigStorage(configStorages);
       } else {
         WxMpConfigStorageHolder.set(mpId);