From beec6031af47b5861953e42c42216ad8110d16ad Mon Sep 17 00:00:00 2001
From: Binary Wang <binarywang@gmail.com>
Date: Sat, 25 Nov 2023 22:25:30 +0800
Subject: [PATCH] =?UTF-8?q?:art:=20=E8=B5=84=E9=87=91=E5=AF=B9=E8=B4=A6?=
 =?UTF-8?q?=E5=8D=95=E4=B8=8B=E8=BD=BD=E6=8E=A5=E5=8F=A3v2=E5=92=8Cv3?=
 =?UTF-8?q?=E6=89=80=E9=9C=80=E8=B5=84=E9=87=91=E8=B4=A6=E6=88=B7=E7=B1=BB?=
 =?UTF-8?q?=E5=9E=8B=E6=9E=9A=E4=B8=BE=E5=80=BC=E4=B8=8D=E4=B8=80=E8=87=B4?=
 =?UTF-8?q?=EF=BC=8C=E5=88=86=E5=BC=80=E5=AD=98=E6=94=BE?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .../WxPayApplyFundFlowBillV3Request.java      | 19 +++++++++++++
 .../request/WxPayDownloadFundFlowRequest.java | 27 ++++++++++++++++---
 .../wxpay/constant/WxPayConstants.java        | 18 -------------
 .../service/impl/BaseWxPayServiceImpl.java    |  1 -
 .../impl/BaseWxPayServiceImplTest.java        |  2 +-
 5 files changed, 44 insertions(+), 23 deletions(-)

diff --git a/weixin-java-pay/src/main/java/com/github/binarywang/wxpay/bean/request/WxPayApplyFundFlowBillV3Request.java b/weixin-java-pay/src/main/java/com/github/binarywang/wxpay/bean/request/WxPayApplyFundFlowBillV3Request.java
index 251465e72..4da2c9b55 100644
--- a/weixin-java-pay/src/main/java/com/github/binarywang/wxpay/bean/request/WxPayApplyFundFlowBillV3Request.java
+++ b/weixin-java-pay/src/main/java/com/github/binarywang/wxpay/bean/request/WxPayApplyFundFlowBillV3Request.java
@@ -16,6 +16,25 @@ import java.io.Serializable;
 @Data
 @NoArgsConstructor
 public class WxPayApplyFundFlowBillV3Request implements Serializable {
+  /**
+   * 账户类型
+   */
+  public static class AccountType {
+    /**
+     * BASIC：基本账户
+     */
+    public static final String BASIC = "BASIC";
+    /**
+     * OPERATION：运营账户
+     */
+    public static final String OPERATION = "OPERATION";
+    /**
+     * FEES：手续费账户
+     */
+    public static final String FEES = "FEES";
+  }
+
+
   private static final long serialVersionUID = 1L;
   /**
    * <pre>
diff --git a/weixin-java-pay/src/main/java/com/github/binarywang/wxpay/bean/request/WxPayDownloadFundFlowRequest.java b/weixin-java-pay/src/main/java/com/github/binarywang/wxpay/bean/request/WxPayDownloadFundFlowRequest.java
index efb14fc7c..5a75b1e48 100644
--- a/weixin-java-pay/src/main/java/com/github/binarywang/wxpay/bean/request/WxPayDownloadFundFlowRequest.java
+++ b/weixin-java-pay/src/main/java/com/github/binarywang/wxpay/bean/request/WxPayDownloadFundFlowRequest.java
@@ -1,6 +1,5 @@
 package com.github.binarywang.wxpay.bean.request;
 
-import com.github.binarywang.wxpay.constant.WxPayConstants.AccountType;
 import com.github.binarywang.wxpay.exception.WxPayException;
 import com.thoughtworks.xstream.annotations.XStreamAlias;
 import lombok.*;
@@ -26,6 +25,27 @@ import java.util.Map;
 @AllArgsConstructor
 @XStreamAlias("xml")
 public class WxPayDownloadFundFlowRequest extends BaseWxPayRequest {
+
+  /**
+   * 账户类型
+   */
+  public static class AccountType {
+    /**
+     * BASIC：基本账户
+     */
+    public static final String BASIC = "Basic";
+    /**
+     * OPERATION：运营账户
+     */
+    public static final String OPERATION = "Operation";
+    /**
+     * FEES：手续费账户
+     */
+    public static final String FEES = "Fees";
+  }
+
+  private static final long serialVersionUID = -8352717499328292952L;
+
   private static final String[] ACCOUNT_TYPES = new String[]{AccountType.BASIC, AccountType.OPERATION, AccountType.FEES};
   private static final String SIGN_TYPE_HMAC_SHA256 = "HMAC-SHA256";
   private static final String TAR_TYPE_GZIP = "GZIP";
@@ -83,8 +103,9 @@ public class WxPayDownloadFundFlowRequest extends BaseWxPayRequest {
       throw new WxPayException(String.format("account_type必须为%s其中之一,实际值：%s",
         Arrays.toString(ACCOUNT_TYPES), this.getAccountType()));
     }
-    /**
-     * 目前仅支持HMAC-SHA256
+
+    /*
+      目前仅支持HMAC-SHA256
      */
     this.setSignType(SIGN_TYPE_HMAC_SHA256);
   }
diff --git a/weixin-java-pay/src/main/java/com/github/binarywang/wxpay/constant/WxPayConstants.java b/weixin-java-pay/src/main/java/com/github/binarywang/wxpay/constant/WxPayConstants.java
index 60a56d100..819cdfe73 100644
--- a/weixin-java-pay/src/main/java/com/github/binarywang/wxpay/constant/WxPayConstants.java
+++ b/weixin-java-pay/src/main/java/com/github/binarywang/wxpay/constant/WxPayConstants.java
@@ -170,24 +170,6 @@ public class WxPayConstants {
     }
   }
 
-  /**
-   * 账户类型
-   */
-  public static class AccountType {
-    /**
-     * BASIC：基本账户
-     */
-    public static final String BASIC = "BASIC";
-    /**
-     * OPERATION：运营账户
-     */
-    public static final String OPERATION = "OPERATION";
-    /**
-     * FEES：手续费账户
-     */
-    public static final String FEES = "FEES";
-  }
-
   /**
    * 签名类型.
    */
diff --git a/weixin-java-pay/src/main/java/com/github/binarywang/wxpay/service/impl/BaseWxPayServiceImpl.java b/weixin-java-pay/src/main/java/com/github/binarywang/wxpay/service/impl/BaseWxPayServiceImpl.java
index 121fd5ae0..8466a5e91 100644
--- a/weixin-java-pay/src/main/java/com/github/binarywang/wxpay/service/impl/BaseWxPayServiceImpl.java
+++ b/weixin-java-pay/src/main/java/com/github/binarywang/wxpay/service/impl/BaseWxPayServiceImpl.java
@@ -971,7 +971,6 @@ public abstract class BaseWxPayServiceImpl implements WxPayService {
 
   @Override
   public WxPayFundFlowResult downloadFundFlow(String billDate, String accountType, String tarType) throws WxPayException {
-
     WxPayDownloadFundFlowRequest request = new WxPayDownloadFundFlowRequest();
     request.setBillDate(billDate);
     request.setAccountType(accountType);
diff --git a/weixin-java-pay/src/test/java/com/github/binarywang/wxpay/service/impl/BaseWxPayServiceImplTest.java b/weixin-java-pay/src/test/java/com/github/binarywang/wxpay/service/impl/BaseWxPayServiceImplTest.java
index e04f146c5..3990f5b61 100644
--- a/weixin-java-pay/src/test/java/com/github/binarywang/wxpay/service/impl/BaseWxPayServiceImplTest.java
+++ b/weixin-java-pay/src/test/java/com/github/binarywang/wxpay/service/impl/BaseWxPayServiceImplTest.java
@@ -11,7 +11,7 @@ import com.github.binarywang.wxpay.bean.result.*;
 import com.github.binarywang.wxpay.bean.result.enums.TradeTypeEnum;
 import com.github.binarywang.wxpay.config.WxPayConfig;
 import com.github.binarywang.wxpay.constant.WxPayConstants;
-import com.github.binarywang.wxpay.constant.WxPayConstants.AccountType;
+import com.github.binarywang.wxpay.bean.request.WxPayDownloadFundFlowRequest.AccountType;
 import com.github.binarywang.wxpay.constant.WxPayConstants.BillType;
 import com.github.binarywang.wxpay.constant.WxPayConstants.SignType;
 import com.github.binarywang.wxpay.constant.WxPayConstants.TradeType;