style: clean code

This commit is contained in:
Fu Diwei
2021-10-18 19:19:51 +08:00
parent 0b3299f091
commit 4092ac467d
11 changed files with 43 additions and 43 deletions

View File

@@ -66,16 +66,16 @@ namespace SKIT.FlurlHttpClient.Wechat.Ads
.CreateRequest(request, HttpMethod.Get, "adcreatives", "get")
.SetQueryParam("access_token", request.AccessToken);
if (request.AdCreativeId.HasValue)
if (request.AdCreativeId != null)
flurlReq.SetQueryParam("adcreative_id", request.AdCreativeId.Value);
if (request.Filters != null && request.Filters.Any())
if (request.Filters != null)
flurlReq.SetQueryParam("filtering", client.JsonSerializer.Serialize(request.Filters));
if (request.PageSize.HasValue)
if (request.PageSize != null)
flurlReq.SetQueryParam("page_size", request.PageSize.Value);
if (request.Page.HasValue)
if (request.Page != null)
flurlReq.SetQueryParam("page", request.Page.Value);
return await client.SendRequestWithJsonAsync<Models.AdCreativesGetResponse>(flurlReq, data: request, cancellationToken: cancellationToken);

View File

@@ -66,16 +66,16 @@ namespace SKIT.FlurlHttpClient.Wechat.Ads
.CreateRequest(request, HttpMethod.Get, "adgroups", "get")
.SetQueryParam("access_token", request.AccessToken);
if (request.AdGroupId.HasValue)
if (request.AdGroupId != null)
flurlReq.SetQueryParam("adgroup_id", request.AdGroupId.Value);
if (request.Filters != null && request.Filters.Any())
if (request.Filters != null)
flurlReq.SetQueryParam("filtering", client.JsonSerializer.Serialize(request.Filters));
if (request.PageSize.HasValue)
if (request.PageSize != null)
flurlReq.SetQueryParam("page_size", request.PageSize.Value);
if (request.Page.HasValue)
if (request.Page != null)
flurlReq.SetQueryParam("page", request.Page.Value);
return await client.SendRequestWithJsonAsync<Models.AdGroupsGetResponse>(flurlReq, data: request, cancellationToken: cancellationToken);

View File

@@ -66,16 +66,16 @@ namespace SKIT.FlurlHttpClient.Wechat.Ads
.CreateRequest(request, HttpMethod.Get, "ads", "get")
.SetQueryParam("access_token", request.AccessToken);
if (request.AdId.HasValue)
if (request.AdId != null)
flurlReq.SetQueryParam("ad_id", request.AdId.Value);
if (request.Filters != null && request.Filters.Any())
if (request.Filters != null)
flurlReq.SetQueryParam("filtering", client.JsonSerializer.Serialize(request.Filters));
if (request.PageSize.HasValue)
if (request.PageSize != null)
flurlReq.SetQueryParam("page_size", request.PageSize.Value);
if (request.Page.HasValue)
if (request.Page != null)
flurlReq.SetQueryParam("page", request.Page.Value);
return await client.SendRequestWithJsonAsync<Models.AdsGetResponse>(flurlReq, data: request, cancellationToken: cancellationToken);

View File

@@ -50,10 +50,10 @@ namespace SKIT.FlurlHttpClient.Wechat.Ads
if (request.Filters != null && request.Filters.Any())
flurlReq.SetQueryParam("filtering", client.JsonSerializer.Serialize(request.Filters));
if (request.PageSize.HasValue)
if (request.PageSize != null)
flurlReq.SetQueryParam("page_size", request.PageSize.Value);
if (request.Page.HasValue)
if (request.Page != null)
flurlReq.SetQueryParam("page", request.Page.Value);
return await client.SendRequestWithJsonAsync<Models.AsyncTasksGetResponse>(flurlReq, data: request, cancellationToken: cancellationToken);

View File

@@ -66,16 +66,16 @@ namespace SKIT.FlurlHttpClient.Wechat.Ads
.CreateRequest(request, HttpMethod.Get, "campaigns", "get")
.SetQueryParam("access_token", request.AccessToken);
if (request.CampaignId.HasValue)
if (request.CampaignId != null)
flurlReq.SetQueryParam("campaign_id", request.CampaignId.Value);
if (request.Filters != null && request.Filters.Any())
if (request.Filters != null)
flurlReq.SetQueryParam("filtering", client.JsonSerializer.Serialize(request.Filters));
if (request.PageSize.HasValue)
if (request.PageSize != null)
flurlReq.SetQueryParam("page_size", request.PageSize.Value);
if (request.Page.HasValue)
if (request.Page != null)
flurlReq.SetQueryParam("page", request.Page.Value);
return await client.SendRequestWithJsonAsync<Models.CampaignsGetResponse>(flurlReq, data: request, cancellationToken: cancellationToken);

View File

@@ -29,10 +29,10 @@ namespace SKIT.FlurlHttpClient.Wechat.Ads
.SetQueryParam("bill_year", request.BillYear)
.SetQueryParam("bill_month", request.BillMonth);
if (request.PageSize.HasValue)
if (request.PageSize != null)
flurlReq.SetQueryParam("page_size", request.PageSize.Value);
if (request.Page.HasValue)
if (request.Page != null)
flurlReq.SetQueryParam("page", request.Page.Value);
return await client.SendRequestWithJsonAsync<Models.CreditBillsGetResponse>(flurlReq, data: request, cancellationToken: cancellationToken);

View File

@@ -67,13 +67,13 @@ namespace SKIT.FlurlHttpClient.Wechat.Ads
.CreateRequest(request, HttpMethod.Get, "custom_audiences", "get")
.SetQueryParam("access_token", request.AccessToken);
if (request.CustomAudienceId.HasValue)
if (request.CustomAudienceId != null)
flurlReq.SetQueryParam("audience_id", request.CustomAudienceId.Value);
if (request.PageSize.HasValue)
if (request.PageSize != null)
flurlReq.SetQueryParam("page_size", request.PageSize.Value);
if (request.Page.HasValue)
if (request.Page != null)
flurlReq.SetQueryParam("page", request.Page.Value);
return await client.SendRequestWithJsonAsync<Models.CustomAudiencesGetResponse>(flurlReq, data: request, cancellationToken: cancellationToken);
@@ -126,16 +126,16 @@ namespace SKIT.FlurlHttpClient.Wechat.Ads
.CreateRequest(request, HttpMethod.Get, "custom_audience_files", "get")
.SetQueryParam("access_token", request.AccessToken);
if (request.CustomAudienceId.HasValue)
if (request.CustomAudienceId != null)
flurlReq.SetQueryParam("audience_id", request.CustomAudienceId.Value);
if (request.CustomAudienceFileId.HasValue)
if (request.CustomAudienceFileId != null)
flurlReq.SetQueryParam("custom_audience_file_id", request.CustomAudienceFileId.Value);
if (request.PageSize.HasValue)
if (request.PageSize != null)
flurlReq.SetQueryParam("page_size", request.PageSize.Value);
if (request.Page.HasValue)
if (request.Page != null)
flurlReq.SetQueryParam("page", request.Page.Value);
return await client.SendRequestWithJsonAsync<Models.CustomAudienceFilesGetResponse>(flurlReq, data: request, cancellationToken: cancellationToken);

View File

@@ -68,13 +68,13 @@ namespace SKIT.FlurlHttpClient.Wechat.Ads
if (request.DateRange != null)
flurlReq.SetQueryParam("date_range", client.JsonSerializer.Serialize(request.DateRange));
if (!string.IsNullOrEmpty(request.TradeType))
if (request.TradeType != null)
flurlReq.SetQueryParam("trade_type", request.TradeType);
if (request.PageSize.HasValue)
if (request.PageSize != null)
flurlReq.SetQueryParam("page_size", request.PageSize.Value);
if (request.Page.HasValue)
if (request.Page != null)
flurlReq.SetQueryParam("page", request.Page.Value);
return await client.SendRequestWithJsonAsync<Models.FundStatementsDetailedGetResponse>(flurlReq, data: request, cancellationToken: cancellationToken);

View File

@@ -26,17 +26,17 @@ namespace SKIT.FlurlHttpClient.Wechat.Ads
if (client is null) throw new ArgumentNullException(nameof(client));
if (request is null) throw new ArgumentNullException(nameof(request));
if (string.IsNullOrEmpty(request.FileName))
if (request.FileName == null)
{
request.FileName = Guid.NewGuid().ToString("N").ToLower();
}
if (string.IsNullOrEmpty(request.FileContentType))
if (request.FileContentType == null)
{
request.FileContentType = Utilities.FileNameToContentTypeMapper.GetContentTypeForImage(request.FileName!) ?? "image/png";
}
if (string.IsNullOrEmpty(request.FileHash))
if (request.FileHash == null)
{
request.FileHash = Security.MD5Utility.Hash(request.FileBytes ?? new byte[0]);
}
@@ -71,16 +71,16 @@ namespace SKIT.FlurlHttpClient.Wechat.Ads
.CreateRequest(request, HttpMethod.Get, "images", "get")
.SetQueryParam("access_token", request.AccessToken);
if (!string.IsNullOrEmpty(request.ImageId))
if (request.ImageId != null)
flurlReq.SetQueryParam("image_id", request.ImageId);
if (request.Filters != null && request.Filters.Any())
if (request.Filters != null)
flurlReq.SetQueryParam("filtering", client.JsonSerializer.Serialize(request.Filters));
if (request.PageSize.HasValue)
if (request.PageSize != null)
flurlReq.SetQueryParam("page_size", request.PageSize.Value);
if (request.Page.HasValue)
if (request.Page != null)
flurlReq.SetQueryParam("page", request.Page.Value);
return await client.SendRequestWithJsonAsync<Models.ImagesGetResponse>(flurlReq, data: request, cancellationToken: cancellationToken);

View File

@@ -31,16 +31,16 @@ namespace SKIT.FlurlHttpClient.Wechat.Ads
if (request.DateRange != null)
flurlReq.SetQueryParam("date_range", client.JsonSerializer.Serialize(request.DateRange));
if (!string.IsNullOrEmpty(request.ReportType))
if (request.ReportType != null)
flurlReq.SetQueryParam("report_type", request.ReportType);
if (!string.IsNullOrEmpty(request.ReportLevel))
if (request.ReportLevel != null)
flurlReq.SetQueryParam("level", request.ReportLevel);
if (request.PageSize.HasValue)
if (request.PageSize != null)
flurlReq.SetQueryParam("page_size", request.PageSize.Value);
if (request.Page.HasValue)
if (request.Page != null)
flurlReq.SetQueryParam("page", request.Page.Value);
return await client.SendRequestWithJsonAsync<Models.DailyReportsGetResponse>(flurlReq, data: request, cancellationToken: cancellationToken);

View File

@@ -64,12 +64,12 @@ namespace SKIT.FlurlHttpClient.Wechat.Ads
{
IFlurlRequest flurlRequest = FlurlClient.Request(urlSegments).WithVerb(method);
if (request.Timeout.HasValue)
if (request.Timeout != null)
{
flurlRequest.WithTimeout(TimeSpan.FromMilliseconds(request.Timeout.Value));
}
if (!string.IsNullOrEmpty(request.Version))
if (request.Version != null)
{
flurlRequest.SetQueryParam("version", request.Version);
}