lsm/Orchard
1
0
Fork 0
mirror of https://github.com/OrchardCMS/Orchard.git synced 2025-11-24 08:46:48 +08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Allow downstream methods to set default value (#8419)

Browse Source 
Moreover, this won't try to set a default value to the bool when it's not sent.
This will allow calls with missing required parameters to fail as they should.
This commit is contained in:
Matteo Piovanelli
2020-09-24 19:15:18 +02:00
committed by GitHub
parent 993e57d7fd
commit 0a41199451
1 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/Orchard/Mvc/ModelBinders/BooleanBinderProvider.cs
View File

@@ -16,7 +16,16 @@ namespace Orchard.Mvc.ModelBinders {
}
public object BindModel(ControllerContext controllerContext, ModelBindingContext bindingContext) {
// returning null from here allows the downstream method to set its own default
var value = false;
if (bindingContext != null) {
if (bindingContext.ValueProvider
?.GetValue(bindingContext.ModelName) == null) {
// this is the case where we are not receiving a possible value for the boolean.
// Returning null is ok here, and will let the downstream method set its own defaults.
return null;
}
}
try {
var attemptedValues = bindingContext.ValueProvider
.GetValue(bindingContext.ModelName)
@@ -34,6 +43,7 @@ namespace Orchard.Mvc.ModelBinders {
// because those won't give us here a list of possible values to aggregate.
} catch {
bindingContext.ModelState.AddModelError(bindingContext.ModelName, new FormatException());
return null;
}
return value;
}