Renamed localization IResourceManager to ILocalizedStringManager to avoid confusion with Orchard.UI.Resources.IResourceManager.

--HG--
branch : dev
rename : src/Orchard/Localization/Services/DefaultResourceManager.cs => src/Orchard/Localization/Services/DefaultLocalizedStringManager.cs
rename : src/Orchard/Localization/Services/IResourceManager.cs => src/Orchard/Localization/Services/ILocalizedStringManager.cs
This commit is contained in:
Dave Reed
2010-09-17 13:22:08 -07:00
parent e3be58604c
commit 3e40d87a06
5 changed files with 13 additions and 13 deletions

View File

@@ -8,7 +8,7 @@ using Orchard.Environment.Extensions;
using Orchard.FileSystems.WebSite;
namespace Orchard.Localization.Services {
public class DefaultResourceManager : IResourceManager {
public class DefaultLocalizedStringManager : ILocalizedStringManager {
private readonly IWebSiteFolder _webSiteFolder;
private readonly ICultureManager _cultureManager;
private readonly IExtensionManager _extensionManager;
@@ -20,7 +20,7 @@ namespace Orchard.Localization.Services {
const string RootLocalizationFilePathFormat = "~/App_Data/Localization/{0}/orchard.root.po";
const string TenantLocalizationFilePathFormat = "~/App_Data/Sites/{0}/Localization/{1}/orchard.po";
public DefaultResourceManager(
public DefaultLocalizedStringManager(
ICultureManager cultureManager,
IWebSiteFolder webSiteFolder,
IExtensionManager extensionManager,

View File

@@ -1,5 +1,5 @@
namespace Orchard.Localization.Services {
public interface IResourceManager : IDependency {
public interface ILocalizedStringManager : IDependency {
string GetLocalizedString(string scope, string text, string cultureName);
}
}

View File

@@ -9,12 +9,12 @@ namespace Orchard.Localization {
public class Text : IText {
private readonly string _scope;
private readonly ICultureManager _cultureManager;
private readonly IResourceManager _resourceManager;
private readonly ILocalizedStringManager _localizedStringManager;
public Text(string scope, ICultureManager cultureManager, IResourceManager resourceManager) {
public Text(string scope, ICultureManager cultureManager, ILocalizedStringManager localizedStringManager) {
_scope = scope;
_cultureManager = cultureManager;
_resourceManager = resourceManager;
_localizedStringManager = localizedStringManager;
Logger = NullLogger.Instance;
}
@@ -24,7 +24,7 @@ namespace Orchard.Localization {
Logger.Debug("{0} localizing '{1}'", _scope, textHint);
string currentCulture = HttpContext.Current == null ? _cultureManager.GetSiteCulture() : _cultureManager.GetCurrentCulture(new HttpContextWrapper(HttpContext.Current));
var localizedFormat = _resourceManager.GetLocalizedString(_scope, textHint, currentCulture);
var localizedFormat = _localizedStringManager.GetLocalizedString(_scope, textHint, currentCulture);
return args.Length == 0
? new LocalizedString(localizedFormat, _scope, textHint, args)

View File

@@ -152,6 +152,8 @@
<Compile Include="DisplayManagement\Descriptors\ShapeTableBuilder.cs" />
<Compile Include="DisplayManagement\Implementation\IShapeFactoryEvents.cs" />
<Compile Include="DisplayManagement\Shapes\ITagBuilderFactory.cs" />
<Compile Include="Localization\Services\DefaultLocalizedStringManager.cs" />
<Compile Include="Localization\Services\ILocalizedStringManager.cs" />
<Compile Include="Mvc\IOrchardViewPage.cs" />
<Compile Include="Mvc\Spooling\HtmlStringWriter.cs" />
<Compile Include="Mvc\ViewEngines\Razor\RazorViewEngine.cs" />
@@ -546,12 +548,10 @@
<Compile Include="Indexing\NullSearchBuilder.cs" />
<Compile Include="Indexing\IIndexNotifierHandler.cs" />
<Compile Include="Localization\Services\DefaultCultureManager.cs" />
<Compile Include="Localization\Services\DefaultResourceManager.cs" />
<Compile Include="Indexing\DefaultIndexManager.cs" />
<Compile Include="Indexing\IIndexManager.cs" />
<Compile Include="Localization\Services\ICultureManager.cs" />
<Compile Include="Localization\Services\ICultureSelector.cs" />
<Compile Include="Localization\Services\IResourceManager.cs" />
<Compile Include="Localization\Records\CultureRecord.cs" />
<Compile Include="Localization\Services\SiteCultureSelector.cs" />
<Compile Include="Mvc\Html\TemplateViewModelExtensions.cs" />

View File

@@ -1,8 +1,8 @@
ResourceManager Notes from Bertrand
====================================
No default parameters
Refactor to take over resource manager name
x No default parameters
x Refactor to take over resource manager name
Better interface pattern for defining resources
Script.Load API that is a view engine specific helper and that directs rendering within the using (using Idisposable pattern) to a buffer that can be rendered later.
Script.Require returns RequireSettings and has fluent api to add stuff later.
@@ -23,12 +23,12 @@ Raw notes from Dave during meeting:
Script.Require("~/modules/mymodule/scripts/foo.min?.js")
Script.Require("/orchardlocal/dfdfd/foo.js")
// no defualt params
// x no defualt params
// better interface/pattern for defining resources
// Script.Load (view-engine specific helper required)
// Script.Require returns RequireSettings and has fluent api?
// Add Script.RequireHead <-- or no due to fluent api
// Rename Localization resource manager
// x Rename Localization resource manager
// Require w/ app relative url means inline definitin of url only, resolved url is resource name
// Site setting for debug mode true false or from web.config setting
// Fix TODO items, including moving all copies of jQuery and jQuery related scripts into the new Orchard.jQuery module.