lsm/Orchard
1
0
Fork 0
mirror of https://github.com/OrchardCMS/Orchard.git synced 2025-08-20 07:23:59 +08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Better solution to skip processing empty filter groups, instead of returning nothing when there's an empty filter group

Browse Source
This commit is contained in:
Benedek Farkas 2024-11-28 11:05:45 +01:00
parent 5114f91526
commit 7e0a8104d3
1 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/Orchard.Web/Modules/Orchard.Projections/Services/ProjectionManager.cs
View File

@ -140,11 +140,6 @@ namespace Orchard.Projections.Services {
var contentItems = new List<ContentItem>();
// If there are no filters, return the empty list of content items instead of returning all content items.
if (queryRecord.FilterGroups.SelectMany(group => group.Filters).Count() == 0) {
return contentItems;
}
// prepares tokens
Dictionary<string, object> tokens = new Dictionary<string, object>();
if (part != null) {
@ -209,8 +204,8 @@ namespace Orchard.Projections.Services {
var version = queryRecord.VersionScope.ToVersionOptions();
// pre-executing all groups
foreach (var group in queryRecord.FilterGroups) {
// Iterate over each filter group, but ignore empty ones, because they'd cause all content items to be returned.
foreach (var group in queryRecord.FilterGroups.Where(group => group.Filters.Count > 0)) {
var contentQuery = _contentManager.HqlQuery().ForVersion(version);
// iterate over each filter to apply the alterations to the query object