lsm/Orchard
1
0
Fork 0
mirror of https://github.com/OrchardCMS/Orchard.git synced 2025-10-15 19:54:57 +08:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

Fixed an issue where unchecked checkboxes would remain checked.

Browse Source 
The issue was that by combining existing element data with posted element data, the existing items would retain their values in case no such item was posted, which is the case for unchecked checkboxes; their name/value pair will  be not posted, so the original value would be retained.
This is fixed by no longer combining existing data with hosted data, but instead relying that an element editor will post all data that it is concerned with.
This commit is contained in:
Sipke Schoorstra
2015-02-28 15:52:37 +01:00
parent 11ffc90afa
commit 9c2e1f9e56
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/Orchard.Web/Modules/Orchard.Layouts/Controllers/ElementController.cs
View File

@@ -104,7 +104,7 @@ namespace Orchard.Layouts.Controllers {
var contentType = sessionState.ContentType;
var describeContext = CreateDescribeContext(contentId, contentType);
var descriptor = _elementManager.GetElementDescriptorByTypeName(describeContext, model.TypeName);
var data = ElementDataHelper.Deserialize(model.ElementData).Combine(Request.Form.ToDictionary());
var data = Request.Form.ToDictionary();
var element = _elementManager.ActivateElement(descriptor, e => e.Data = data);
var context = CreateEditorContext(session, describeContext.Content, element, elementData: data, updater: this);
var editorResult = _elementManager.UpdateEditor(context);
@@ -190,7 +190,7 @@ namespace Orchard.Layouts.Controllers {
var contentType = sessionState.ContentType;
var describeContext = CreateDescribeContext(contentId, contentType);
var descriptor = _elementManager.GetElementDescriptorByTypeName(describeContext, model.TypeName);
var data = ElementDataHelper.Deserialize(model.ElementData).Combine(Request.Form.ToDictionary());
var data = Request.Form.ToDictionary();
var element = _elementManager.ActivateElement(descriptor, e => e.Data = data);
var context = CreateEditorContext(session, describeContext.Content, element, data, updater: this);
var editorResult = _elementManager.UpdateEditor(context);