lsm/Orchard
1
0
Fork 0
mirror of https://github.com/OrchardCMS/Orchard.git synced 2025-10-15 19:54:57 +08:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

Executing scheduled tasks in separate transactions

Browse Source 
--HG--
branch : 1.x
This commit is contained in:
Sebastien Ros
2013-04-23 10:48:33 -07:00
parent deb3c8d72d
commit d07a53337f
1 changed files with 6 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/Orchard.Web/Core/Scheduling/Services/ScheduledTaskExecutor.cs
View File

@@ -17,16 +17,19 @@ namespace Orchard.Core.Scheduling.Services {
private readonly IRepository<ScheduledTaskRecord> _repository;
private readonly IEnumerable<IScheduledTaskHandler> _handlers;
private readonly IContentManager _contentManager;
private readonly ITransactionManager _transactionManager;
public ScheduledTaskExecutor(
IClock clock,
IRepository<ScheduledTaskRecord> repository,
IEnumerable<IScheduledTaskHandler> handlers,
IContentManager contentManager) {
IContentManager contentManager,
ITransactionManager transactionManager) {
_clock = clock;
_repository = repository;
_handlers = handlers;
_contentManager = contentManager;
_transactionManager = transactionManager;
Logger = NullLogger.Instance;
}
@@ -38,7 +41,7 @@ namespace Orchard.Core.Scheduling.Services {
.ToArray();
foreach (var taskEntry in taskEntries) {
//TODO: start a dedicated transaction scope
_transactionManager.RequireNew();
try {
// fetch the task
@@ -60,14 +63,10 @@ namespace Orchard.Core.Scheduling.Services {
foreach (var handler in _handlers) {
handler.Process(context);
}
//TODO: commit dedicated scope
}
catch (Exception ex) {
Logger.Warning(ex, "Unable to process scheduled task #{0} of type {1}", taskEntry.Id, taskEntry.Action);
//TODO: handle exception to rollback dedicated xact, and re-delete task record.
// does this also need some retry logic?
_transactionManager.Cancel();
}
}
}