lsm/Orchard
1
0
Fork 0
mirror of https://github.com/OrchardCMS/Orchard.git synced 2025-10-15 19:54:57 +08:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

EnableFeature: added code to throw meaningful exceptions if module dependencies not found

Browse Source
This commit is contained in:
Volodymyr Usarskyy
2013-09-29 21:38:27 +02:00
committed by Sebastien Ros
parent 5ea04ac0f0
commit e1fc329a75
1 changed files with 22 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
src/Orchard/Environment/Features/FeatureManager.cs
View File

@@ -138,17 +138,29 @@ namespace Orchard.Environment.Features {
/// <param name="force">Boolean parameter indicating if the feature should enable it's dependencies if required or fail otherwise.</param>
/// <returns>An enumeration of the enabled features.</returns>
private IEnumerable<string> EnableFeature(string featureId, IDictionary<FeatureDescriptor, bool> availableFeatures, bool force) {
var getDisabledDependencies =
new Func<string, IDictionary<FeatureDescriptor, bool>, IDictionary<FeatureDescriptor, bool>>(
(currentFeatureId, featuresState) => {
KeyValuePair<FeatureDescriptor, bool> feature = featuresState.Single(featureState => featureState.Key.Id.Equals(currentFeatureId, StringComparison.OrdinalIgnoreCase));
var getDisabledDependencies =
new Func<string, IDictionary<FeatureDescriptor, bool>, IDictionary<FeatureDescriptor, bool>>(
(currentFeatureId, featuresState) => {
KeyValuePair<FeatureDescriptor, bool> feature = featuresState.Single(featureState => featureState.Key.Id.Equals(currentFeatureId, StringComparison.OrdinalIgnoreCase));
// Retrieve disabled dependencies for the current feature
return feature.Key.Dependencies
.Select(fId => featuresState.Single(featureState => featureState.Key.Id.Equals(fId, StringComparison.OrdinalIgnoreCase)))
.Where(featureState => !featureState.Value)
.ToDictionary(f => f.Key, f => f.Value);
});
// Retrieve disabled dependencies for the current feature
return feature.Key.Dependencies
.Select(fId => {
var states = featuresState.Where(featureState => featureState.Key.Id.Equals(fId, StringComparison.OrdinalIgnoreCase)).ToList();
if (states.Count == 0) {
throw new ApplicationException("Failed to get state for feature " + fId);
}
if (states.Count > 1) {
throw new ApplicationException("Found " + states.Count + " states for feature " + fId);
}
return states[0];
})
.Where(featureState => !featureState.Value)
.ToDictionary(f => f.Key, f => f.Value);
});
IEnumerable<string> featuresToEnable = GetAffectedFeatures(featureId, availableFeatures, getDisabledDependencies);
if (featuresToEnable.Count() > 1 && !force) {