* Fixing that Core.Containers "Show on admin menu" functionality shouldn't depend on the Orchard.Lists feature
* Moving menu.list.png admin menu icon from Orchard.Lists to Core.Containers as menu.container.png
to fix that Containers should have a default admin menu icon
* Fixing conflict between lists and container admin navicon by applying the unused menu.list-definition.png to lists
* Code styling and removing duplicate code
* Using Title Casing in the Compile workflow's step names
* Adding step to run the Setup with SpecFlow
* Fixing typo
* Fixing that upgrading Newtonsoft.Json to 13.x broke the SpecFlow test execution app
* #6986 Created feature Media Processing Html Filter
* Fixing HtmlAgilityPack and upgrading FW and package version to match Orchard.Specs
* Adapting MediaProcessingHtmlFilter to IHtmlFilter breaking change
* Fixing that Orchard.MediaProcessingHtmlFilter should depend on Orchard.MediaProcessing
* Code styling
* Using regexes instead of HtmlAgilityPack, thanks GHCP
* Updating comments and code styling
* Code styling
* Reworking ProcessContent to use StringBuilder instead of replaces
* Fixing that GetAttributeRegex should find attributes with empty value
* Code styling
* Fixing that detecting the extension works regardless of casing
but it still works with Azure Blob Storage (which is case-sensitive) too
* Optimizing image tag regex
* Caching attribute regexes
* Caching attribute values of img tags
* Simplifying attribute value cache
---------
Co-authored-by: Arjan Noordende <arjan@zumey.com>
* Updating Npgsql to version 4.0.17 (the latest minor version of the closest major version that isn't vulnerable)
https://github.com/OrchardCMS/Orchard/security/dependabot/54
* Fixing that Projection Migrations created indexes with the same name in different tables, which is not supported by PostgreSQL
* Cleaning up Core/Navigation/Controllers/AdminController
* Extending Core/Navigation/Controllers/AdminController to be able to publish/unpublish menuitems
* Redirecting to menu when saving a menu item and using the menu item text in the notification
* Fixing that saving a menu item shouldn't publish it if it's unpublished
* Using the menu item text in the notification when publishing and unpublishing too
* Updating Compile workflow with setup and code generation steps
* Updating NHibernate reference and OrchardBasicCorrectness.ruleset path in ModuleTestsCsProj code generation template
* Ignoring CS2008 warning when recompiling with generated modules, because the theme and test projects don't have .cs files
* Generating a test project should also include packages.config
* Fixing the relative path of Orchard.Core and Orchard.Framework in the generated test project
* A bit of code styling in the Compile workflow
* Updating Readme
* Revert "A bit of code styling in the Compile workflow"
This reverts commit 7b01ebbad0.
* Updating System.IdentityModel.Tokens.Jwt and its dependencies in Orchard.Azure.MediaServices
* Using System.IO.Compression instead of DotNetZip
* Upgrading Newtonsoft.Json from 12.0.3 (vulnerable) to 13.0.3
* Updating ModuleRootWebConfig.txt codegen template according to the new Newtonsoft.Json version
* #6981 Normalized image profile path hash and added profile purging
* Profile purge functions rather belong in IImageProfileService
* Deleting an Image Profile now also removes all its files too
* Comment formatting
* Caching the value of the "Orchard.MediaProcessing.NormalizePath" app setting in ImageProfileManager
* Code styling in ImageProfileManager
* Formatting and code styling ImageProfileManager
---------
Co-authored-by: Arjan Noordende <arjan@zumey.com>
* 6748: Stricter file and folder name validation (#6792)
* Media Library: More strict file and folder name validation, fixes#6748
* Resetting MediaLibraryService changes to 1.10.x
* Code styling in FileSystemStorageProvider
* Adding string file and folder name validation to FileSystemStorageProvider, so that MediaLibrary components don't need to do it separately
* Applying the same file and folder name validation to AzureFileSystem too
* Code styling and fixes in AzureFileSystem, MediaLibrary and IStorageProvider
* Simplifying invalid character detection
* Code styling
* Adding InvalidNameCharacterException to be able to handle invalid characters precisely at various user-facing components
* Updating MediaLibrary not to log an error when a file can't be uploaded due to invalid characters
---------
Co-authored-by: Lombiq <github@lombiq.com>
* #6793: Adding a content-independent culture selector shape for the front-end (#8784)
* Adds a new CultureSelector shape for front-end
* fixed query string culture change
* Moving NameValueCollectionExtensions from Orchard.DynamicForms and Orchard.Localization to Orchard.Framework
* Code styling
* Simplifying UserCultureSelectorController and removing the addition of the culture to the query string
* EOF empty lines and code styling
* Fixing that the main Orchard.Localization should depend on Orchard.Autoroute
* Code styling in LocalizationService
* Updating LocalizationService to not have to use IEnumerable.Single
* Matching culture name matching in LocalizationService culture- and casing-invariant
---------
Co-authored-by: Sergio Navarro <jersio@hotmail.com>
Co-authored-by: psp589 <pablosanchez589@gmail.com>
* #8640: Fixing consistency between different Enumeration Field flavors' data storage (#8789)
* Reworking EnumerationField's logic to store/retrieve its (selected) values
* Fixing exception when creating new item with CheckboxList flavor, adding more nullchecks and compactness
* Code styling in EnumerationFieldDriver
* Code styling in EnumerationField editor template
* Fixing that EnumerationFieldDriver and the EnumerationField editor template should read SelectedValues instead of Values directly
---------
Co-authored-by: Matteo Piovanelli <MatteoPiovanelli-Laser@users.noreply.github.com>
* Fixing merge
---------
Co-authored-by: Lombiq <github@lombiq.com>
Co-authored-by: Sergio Navarro <jersio@hotmail.com>
Co-authored-by: psp589 <pablosanchez589@gmail.com>
Co-authored-by: Matteo Piovanelli <MatteoPiovanelli-Laser@users.noreply.github.com>
* Reworking EnumerationField's logic to store/retrieve its (selected) values
* Fixing exception when creating new item with CheckboxList flavor, adding more nullchecks and compactness
* Code styling in EnumerationFieldDriver
* Code styling in EnumerationField editor template
* Fixing that EnumerationFieldDriver and the EnumerationField editor template should read SelectedValues instead of Values directly
---------
Co-authored-by: Matteo Piovanelli <MatteoPiovanelli-Laser@users.noreply.github.com>
* Adds a new CultureSelector shape for front-end
* fixed query string culture change
* Moving NameValueCollectionExtensions from Orchard.DynamicForms and Orchard.Localization to Orchard.Framework
* Code styling
* Simplifying UserCultureSelectorController and removing the addition of the culture to the query string
* EOF empty lines and code styling
* Fixing that the main Orchard.Localization should depend on Orchard.Autoroute
* Code styling in LocalizationService
* Updating LocalizationService to not have to use IEnumerable.Single
* Matching culture name matching in LocalizationService culture- and casing-invariant
---------
Co-authored-by: Sergio Navarro <jersio@hotmail.com>
Co-authored-by: psp589 <pablosanchez589@gmail.com>
* Media Library: More strict file and folder name validation, fixes#6748
* Resetting MediaLibraryService changes to 1.10.x
* Code styling in FileSystemStorageProvider
* Adding string file and folder name validation to FileSystemStorageProvider, so that MediaLibrary components don't need to do it separately
* Applying the same file and folder name validation to AzureFileSystem too
* Code styling and fixes in AzureFileSystem, MediaLibrary and IStorageProvider
* Simplifying invalid character detection
* Code styling
* Adding InvalidNameCharacterException to be able to handle invalid characters precisely at various user-facing components
* Updating MediaLibrary not to log an error when a file can't be uploaded due to invalid characters
---------
Co-authored-by: Lombiq <github@lombiq.com>
* Updating Microsoft.IdentityModel.* packages from 5.2.4 to 5.7.0
* Updating OpenId packages from 4.0.0 to 4.2.2 to mach the version of Microsoft.Owin
* Fixing assembly binding redirects in Orchard.Web/Web.config
* OpenId: Updating Microsoft.IdentityModel.Tokens.* packages to version 5.7.0.0 to match Microsoft.IdentityModel.Tokens
* OpenId: Updating Microsoft.IdentityModel.Protocols packages to 5.7.0.0 too
* The return of System.Net.Http assembly binding redirects
* Adding a checkbox to StringFilterForm to control whether an empty value should cause the filter to be skipped
* Removing StringOperator.ContainsAnyIfProvided as its now obsolete due to the IgnoreFilterIfValueIsEmpty checkbox setting
* Code styling in StringFilterForm
* Adding missing T-string
* Adding migration step to upgrade from using the ContainsAnyIfProvided operator in StringFilterForm
* Updating rebuilt client-side assets that only changed in terms of sourceMappingURL
* Updating rebuilt client-side assets that changed functionally
* Fixing/simplifying Layout editor toolbox stickyness and height restriction to viewport
* Compile workflow: Upgrading actions/checkout and microsoft/setup-msbuild actions to their latest versions
* Compile workflow: Adding steps to validate that the client-side assets are up-to-date
* Compile workflow: Temporarily disabling MSBuild steps
* Moving client-side assets build to a separate job in the compile workflow
* Updating client-side compilation job
* Temporarily disabling the .NET build
* Separating package install from asset rebuild
* Adding debug command
* Fixing working directory
* Debugging
* Attempting to get rid of false positives due to line ending changes
* Removing debug code
* Checking asset validation by modifying Orchard.Resources/Assets/Less/Bootstrap/variables.less, but not its derivatives
* Revert "Checking asset validation by modifying Orchard.Resources/Assets/Less/Bootstrap/variables.less, but not its derivatives"
This reverts commit 3fc9b8362b.
* Revert "Temporarily disabling the .NET build"
This reverts commit 2a8fef7793.
* Fixing error message when client-side assets are not up-to-date
* Upgrading projects, code generation templates and Specflow app to use Microsoft.CodeDom.Providers.DotNetCompilerPlatform 4.1.0 (latest)
* Updating csprojs not to define LangVersion separately in Release and Debug mode, setting it to "default" instead of "latest"
* Restricting C# language version to 7.3
* Downgrading SmtpMessageChannel.cs to C# 7.3
* Setting MvcBuildViews = false in the remaining csprojs that reference DotNetCompilerPlatform, like the others
* Setting RoslynCopyToOutDir = false in each csproj that references DotNetCompilerPlatform
See https://github.com/aspnet/RoslynCodeDomProvider?tab=readme-ov-file#build-time-options
- We only need Orchard.Web to include the Roslyn tools in its bin folder, the other csprojs only need the DLL reference
- We could simply remove the targets import in these csprojs, but it will be re-added when the package is updated, so this is cleaner/easier
* We don't actually need <MvcBuildViews>false</MvcBuildViews> in csprojs
* Orchard.Web: Copying Roslyn files to the output folder using the provided target (CopyRoslynCompilerFilesToOutputDirectory) instead of our custom one
* Orchard.proj: Factoring out a part of the Compile target into the DevCompile target and removing BuildViews target
- For a simple local build (just to validate that the solution builds), we don't actually need that second build that copies files to the output folder.
- CI builds (Test, Spec, etc.) that operate on the build output folder are unaffected, because Compile calls DevCompile
- The BuildViews target is not really necessary, just call any other target (Compile, DevCompile, Spec, etc.) with "/p:MvcBuildViews=true"
* Removing incorrect comment about Razor IntelliSense
* Removing VBCodeProvider configuration from Web.config files
* Getting rid of Microsoft.CodeDom.Providers.DotNetCompilerPlatform.targets imports and associated configuration except in Orchard.Web.csproj
* Adding VB compiler configuration to src/Orchard.Web/Web.config, because it would be readded on rebuild by the imported target anyway
They were just rendered as a small, empty rectangle:
- Unassign Role activity styling was syntactically incorrect
- Send Email and Is In Role activity styling file name did not match what the Workflows ResourceManifest expects
"Cannot compile modules using option 'outFile' unless the '--module' flag is 'amd' or 'system'"
Also recompiling client-side assets, but the changes are not the result of the compiler option change, they were just outdated
* Fixing that RecipeManagerTests failed due to HttpContext not being available
* Fixing OwnerEditor tests in CommonPartProviderTests as the owner editor now checks for a different permission since 5b0c82d1ad
* Fixing typo in CommonPartProviderTests.UpdateModelStub class name
* Fixing that test cases for invalid path in FileSystemStorageProviderTests broke in a3e9bef3ca (issue #6802, PR #6919)
I should review PRs more carefully!
* Fixing CurrentCultureWorkContextTests
* Fixing indentation in DefaultDateFormatterTests
* Updating Orchard.Azure.Web's required version of System.Web.Mvc to match the rest of the solution
* Orchard.Specs: Fixing assembly loading errors when starting up the web host by adding binding redirects
* Adding empty compile workflow from dev
* Adding the compile workflow's actual contents
* Changing default shell to pwsh (msbuild was not found in cmd?)
* Adding msbuild to PATH
* Removing unused references to System.Net.Http
* Replacing System.Net.Http references with its NuGet package to pin the correct version number (experimental)
* Upgrading Microsoft.CodeDom.Providers.DotNetCompilerPlatform to 4.1.0 (latest) to get rid of old System.Http.Net dependency
* Orchard.proj: Spec target actually depends on only the Compile target, not Package-Stage (experimental)
* Compile workflow: Testing the Test and Spec targets
* Fixing Test step
* Fixing compile workflow to also mark Razor compilation warnings as errors
* Restoring Orchard.Specs/Hosting/Orchard.Web/Web.config to match Orchard.Web's web.config closer
so that it loads assemblies from the Dependencies folder.
This fixes the error with Autofac not being able to resolve dependencies for DefaultOrchardShell
* Orchard.Specs/Hosting/Orchard.Web/Global.asax.cs: Workaround for AntiForgeryToken bug in ASP.NET MVC since version 5.2.4
https://github.com/aspnet/AspNetWebStack/issues/162
* Revert "Replacing System.Net.Http references with its NuGet package to pin the correct version number (experimental)"
This reverts commit 087f2849b1.
* Revert "Upgrading Microsoft.CodeDom.Providers.DotNetCompilerPlatform to 4.1.0 (latest) to get rid of old System.Http.Net dependency"
This reverts commit be2ba866e3.
* Reverting the addition of assembly binding redirects to Orchard.Specs/Hosting/Simple.Web/Web.config
since it doesn't need them like Orchard.Specs/Hosting/Orchard.Web/Web.config does
* Disabling Test and Spec execution for now
* Orchard.Framework: Making the System.Net.Http not-private to prevent an outdated version sticking around
* Orchard.Workflows: Adding assembly binding redirect for System.Net.Http to avoid Razor compilation warning
* Moving the System.Net.Http assembly redirect to Orchard.Web
* Specs: Fixing "I can create browse blog posts on several pages" Blog test's usage of "I should not see" and correcting the parameters too
because unlike "I should see", this is not a regex match, just contains
* Specs: Fixing "I can create browse blog posts on several pages" Blog test's flakyness due to timing
because the blog posts are created quickly after one another and the lack of millisecond-precision can cause
the blog posts to appear out of order of creation
* Specs: Media test simplified since the Orchard.Media feature is deprecated
* Adding step to the Compile workflow to upload the MSBuild binlog results
* Pinning the referenced version of System.Net.Http to 4.2.0.0 to prevent Razor compilation warning
System.Net.Http is known to have such problems across different framework versions ways of referencing it
The original warning is:
ASPNETCOMPILER : error : The following assembly has dependencies on a version of the .NET Framework that is higher than the target and might not load correctly during runtime causing a failure: Orchard.Workflows, Version=1.10.3.0, Culture=neutral, PublicKeyToken=null. The dependencies are: System.Net.Http, Version=4.2.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a. You should either ensure that the dependent assembly is correct for the target framework, or ensure that the target framework you are addressing is that of the dependent assembly. [D:\a\Orchard\Orchard\src\Orchard.Web\Modules\Orchard.Workflows\Orchard.Workflows.csproj
* Re-enabling the Test step
* Re-enabling the Specs step
* Marking System.Net.Http references as private (copy local) to make sure that it's always available, because it requires a specific version
* Revert "Marking System.Net.Http references as private (copy local) to make sure that it's always available, because it requires a specific version"
This reverts commit e4f5632236.
* Orchard.Specs: Adding Settings feature
* Orchard.Specs: Updating DateTime.CreatingAndUsingDateTimeFieldsInAnotherCulture structure without functional change
* Orchard.Specs: Updating Settings.AddingANewSiteCultureAndSelectingItAsTheDefaultWorks to correctly detect that a culture that wasn't added before can be set as default
* Fixing outdated assembly binding redirects
* Fixing Newtonsoft.Json references
* Updating Newtonsoft.Json reference in Orchard.Messaging.Tests.csproj
* Disabling the Test step for now
* Adding System.Net.Http 4.2.0.0 reference to Orchard.Email's web.config to fix Razor compilation warning
* Re-enabling the Test step
* Fixing HqlExpressionTests.AllDataTypesCanBeQueried
* Fixing initialization error error in StylesheetBindingStrategyTests
* Fixing initialization errors in FeatureManagerTests
* Fixing Orchard.Tests.Localization.TextTests
* Code styling and fixing warning in Orchard.Tests/UI/Resources/ResourceManagerTests.cs
* Updating Orchard.Tests/UI/Resources/ResourceManagerTests.cs according to ResourceManager API change in ac11024be4
and removing obsolete tests
* Orchard.Tests.Modules: Adding missing reference to Iesi.Collections (that doesn't cause a build error, just when running tests)
* Fixing initialization errors in ModuleStepTest and ThemeStepTest
* Fixing initialization errors in ShellDescriptorManagerTests
* Fixing initialization errors in AccountControllerTests
* Fixing that MembershipServiceTests should use IPasswordService, also making SaltAndPasswordShouldBeDifferentEvenWithSameSourcePassword test parameters more readable
* Specs: Updating the Newtonsoft.Json binding redirect in the spec app's web.config
* Re-enabling the Spec step
* Upgrading actions to latest versions
These actions generated the Node.js 16 deprecation warning
* Removing SpecFlow test execution from the compile workflow
* Testing the branch strategy matrix concept to be used for the nightly build
* Revert "Testing the branch strategy matrix concept to be used for the nightly build"
This reverts commit 1354e367b7.
* Adding workflow to run specflow tests as a nightly build
* Updating Orchard.Tests.ContentManagement.HqlExpressionTests.ShouldSortRandomly to decrease failure chance due to randomness
* Fixing that RecipeManagerTests failed due to HttpContext not being available
* Fixing OwnerEditor tests in CommonPartProviderTests as the owner editor now checks for a different permission since 5b0c82d1ad
* Fixing typo in CommonPartProviderTests.UpdateModelStub class name
* Fixing that test cases for invalid path in FileSystemStorageProviderTests broke in a3e9bef3ca (issue #6802, PR #6919)
I should review PRs more carefully!
* Fixing CurrentCultureWorkContextTests
* Fixing indentation in DefaultDateFormatterTests
* Updating Orchard.Azure.Web's required version of System.Web.Mvc to match the rest of the solution
* Orchard.Specs: Fixing assembly loading errors when starting up the web host by adding binding redirects
* Adding empty compile workflow from dev
* Adding the compile workflow's actual contents
* Changing default shell to pwsh (msbuild was not found in cmd?)
* Adding msbuild to PATH
* Removing unused references to System.Net.Http
* Replacing System.Net.Http references with its NuGet package to pin the correct version number (experimental)
* Upgrading Microsoft.CodeDom.Providers.DotNetCompilerPlatform to 4.1.0 (latest) to get rid of old System.Http.Net dependency
* Orchard.proj: Spec target actually depends on only the Compile target, not Package-Stage (experimental)
* Compile workflow: Testing the Test and Spec targets
* Fixing Test step
* Fixing compile workflow to also mark Razor compilation warnings as errors
* Restoring Orchard.Specs/Hosting/Orchard.Web/Web.config to match Orchard.Web's web.config closer
so that it loads assemblies from the Dependencies folder.
This fixes the error with Autofac not being able to resolve dependencies for DefaultOrchardShell
* Orchard.Specs/Hosting/Orchard.Web/Global.asax.cs: Workaround for AntiForgeryToken bug in ASP.NET MVC since version 5.2.4
https://github.com/aspnet/AspNetWebStack/issues/162
* Revert "Replacing System.Net.Http references with its NuGet package to pin the correct version number (experimental)"
This reverts commit 087f2849b1.
* Revert "Upgrading Microsoft.CodeDom.Providers.DotNetCompilerPlatform to 4.1.0 (latest) to get rid of old System.Http.Net dependency"
This reverts commit be2ba866e3.
* Reverting the addition of assembly binding redirects to Orchard.Specs/Hosting/Simple.Web/Web.config
since it doesn't need them like Orchard.Specs/Hosting/Orchard.Web/Web.config does
* Disabling Test and Spec execution for now
* Orchard.Framework: Making the System.Net.Http not-private to prevent an outdated version sticking around
* Orchard.Workflows: Adding assembly binding redirect for System.Net.Http to avoid Razor compilation warning
* Moving the System.Net.Http assembly redirect to Orchard.Web
* Specs: Fixing "I can create browse blog posts on several pages" Blog test's usage of "I should not see" and correcting the parameters too
because unlike "I should see", this is not a regex match, just contains
* Specs: Fixing "I can create browse blog posts on several pages" Blog test's flakyness due to timing
because the blog posts are created quickly after one another and the lack of millisecond-precision can cause
the blog posts to appear out of order of creation
* Specs: Media test simplified since the Orchard.Media feature is deprecated
* Adding step to the Compile workflow to upload the MSBuild binlog results
* Pinning the referenced version of System.Net.Http to 4.2.0.0 to prevent Razor compilation warning
System.Net.Http is known to have such problems across different framework versions ways of referencing it
The original warning is:
ASPNETCOMPILER : error : The following assembly has dependencies on a version of the .NET Framework that is higher than the target and might not load correctly during runtime causing a failure: Orchard.Workflows, Version=1.10.3.0, Culture=neutral, PublicKeyToken=null. The dependencies are: System.Net.Http, Version=4.2.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a. You should either ensure that the dependent assembly is correct for the target framework, or ensure that the target framework you are addressing is that of the dependent assembly. [D:\a\Orchard\Orchard\src\Orchard.Web\Modules\Orchard.Workflows\Orchard.Workflows.csproj
* Re-enabling the Test step
* Re-enabling the Specs step
* Marking System.Net.Http references as private (copy local) to make sure that it's always available, because it requires a specific version
* Revert "Marking System.Net.Http references as private (copy local) to make sure that it's always available, because it requires a specific version"
This reverts commit e4f5632236.
* Orchard.Specs: Adding Settings feature
* Orchard.Specs: Updating DateTime.CreatingAndUsingDateTimeFieldsInAnotherCulture structure without functional change
* Orchard.Specs: Updating Settings.AddingANewSiteCultureAndSelectingItAsTheDefaultWorks to correctly detect that a culture that wasn't added before can be set as default
* Fixing Newtonsoft.Json references
* Specs: Workaround for the DefineDefaultCulture binding and removing the Settings feature which is now redundant with CreatingAndUsingDateTimeFieldsInAnotherCulture
* Updating the compile workflow to run the build + tests on PR, dev and 1.10.x commits
* Adding the compile workflow to the solution
Benedek Farkas