lsm/konva
1
0
Fork 0
mirror of https://github.com/konvajs/konva.git synced 2025-10-14 11:44:55 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

a bit better performance

Browse Source
This commit is contained in:
Anton Lavrenov
2020-09-17 14:35:46 -05:00
parent 4ce6800fd9
commit 6fffed9e70
3 changed files with 47 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files

46
konva.js
View File

@@ -2624,7 +2624,7 @@
}
};
// CONSTANTS
var ABSOLUTE_OPACITY = 'absoluteOpacity', ABSOLUTE_TRANSFORM = 'absoluteTransform', ABSOLUTE_SCALE = 'absoluteScale', CANVAS = 'canvas', CHANGE = 'Change', CHILDREN = 'children', KONVA = 'konva', LISTENING = 'listening', MOUSEENTER = 'mouseenter', MOUSELEAVE = 'mouseleave', NAME = 'name', SET$1 = 'set', SHAPE = 'Shape', SPACE = ' ', STAGE = 'stage', TRANSFORM = 'transform', UPPER_STAGE = 'Stage', VISIBLE = 'visible', TRANSFORM_CHANGE_STR = [
var ABSOLUTE_OPACITY = 'absoluteOpacity', ALL_LISTENERS = 'allEventListeners', ABSOLUTE_TRANSFORM = 'absoluteTransform', ABSOLUTE_SCALE = 'absoluteScale', CANVAS = 'canvas', CHANGE = 'Change', CHILDREN = 'children', KONVA = 'konva', LISTENING = 'listening', MOUSEENTER = 'mouseenter', MOUSELEAVE = 'mouseleave', NAME = 'name', SET$1 = 'set', SHAPE = 'Shape', SPACE = ' ', STAGE = 'stage', TRANSFORM = 'transform', UPPER_STAGE = 'Stage', VISIBLE = 'visible', TRANSFORM_CHANGE_STR = [
'xChange.konva',
'yChange.konva',
'scaleXChange.konva',
@@ -3090,7 +3090,7 @@
* });
*/
Node.prototype.on = function (evtStr, handler) {
// this._cache && this._cache.delete(ALL_LISTENERS);
this._cache && this._cache.delete(ALL_LISTENERS);
if (arguments.length === 3) {
return this._delegate.apply(this, arguments);
}
@@ -3139,6 +3139,7 @@
*/
Node.prototype.off = function (evtStr, callback) {
var events = (evtStr || '').split(SPACE), len = events.length, n, t, event, parts, baseEvent, name;
this._cache && this._cache.delete(ALL_LISTENERS);
if (!evtStr) {
// remove all events
for (t in this.eventListeners) {
@@ -4503,33 +4504,30 @@
}
};
Node.prototype._getListeners = function (eventType) {
// const events = this._cache.get(ALL_LISTENERS);
// if (events && events[eventType]) {
// return events[eventType];
// }
var totalEvents = [];
var obj;
while (true) {
obj = obj ? Object.getPrototypeOf(obj) : this;
if (!obj) {
break;
var listeners = this._cache.get(ALL_LISTENERS);
// if no cache for listeners, we need to pre calculate it
if (!listeners) {
listeners = {};
var obj = this;
while (obj) {
if (!obj.eventListeners) {
obj = Object.getPrototypeOf(obj);
continue;
}
for (var event in obj.eventListeners) {
var newEvents = obj.eventListeners[event];
var oldEvents = listeners[event] || [];
listeners[event] = newEvents.concat(oldEvents);
}
obj = Object.getPrototypeOf(obj);
}
if (!obj.eventListeners) {
continue;
}
var events = obj.eventListeners[eventType];
if (!events) {
continue;
}
totalEvents = events.concat(totalEvents);
obj = Object.getPrototypeOf(obj);
this._cache.set(ALL_LISTENERS, listeners);
}
// this._cache.set(ALL_LISTENERS, totalEvents);
return totalEvents;
return listeners[eventType];
};
Node.prototype._fire = function (eventType, evt) {
var events = this._getListeners(eventType), i;
if (events.length) {
if (events) {
evt = evt || {};
evt.currentTarget = this;
evt.type = eventType;

2
konva.min.js vendored
View File

File diff suppressed because one or more lines are too long

47
src/Node.ts
View File

@@ -721,7 +721,8 @@ export abstract class Node<Config extends NodeConfig = NodeConfig> {
evtStr: K,
handler: KonvaEventListener<this, NodeEventMap[K]>
) {
// this._cache && this._cache.delete(ALL_LISTENERS);
this._cache && this._cache.delete(ALL_LISTENERS);
if (arguments.length === 3) {
return this._delegate.apply(this, arguments);
}
@@ -788,6 +789,8 @@ export abstract class Node<Config extends NodeConfig = NodeConfig> {
baseEvent,
name;
this._cache && this._cache.delete(ALL_LISTENERS);
if (!evtStr) {
// remove all events
for (t in this.eventListeners) {
@@ -2278,36 +2281,34 @@ export abstract class Node<Config extends NodeConfig = NodeConfig> {
}
_getListeners(eventType) {
// const events = this._cache.get(ALL_LISTENERS);
// if (events && events[eventType]) {
// return events[eventType];
// }
let listeners = this._cache.get(ALL_LISTENERS);
// if no cache for listeners, we need to pre calculate it
if (!listeners) {
listeners = {};
let obj = this;
while (obj) {
if (!obj.eventListeners) {
obj = Object.getPrototypeOf(obj);
continue;
}
for (var event in obj.eventListeners) {
const newEvents = obj.eventListeners[event];
const oldEvents = listeners[event] || [];
let totalEvents = [];
let obj;
while (true) {
obj = obj ? Object.getPrototypeOf(obj) : this;
if (!obj) {
break;
listeners[event] = newEvents.concat(oldEvents);
}
obj = Object.getPrototypeOf(obj);
}
if (!obj.eventListeners) {
continue;
}
const events = obj.eventListeners[eventType];
if (!events) {
continue;
}
totalEvents = events.concat(totalEvents);
obj = Object.getPrototypeOf(obj);
this._cache.set(ALL_LISTENERS, listeners);
}
// this._cache.set(ALL_LISTENERS, totalEvents);
return totalEvents;
return listeners[eventType];
}
_fire(eventType, evt) {
var events = this._getListeners(eventType),
i;
if (events.length) {
if (events) {
evt = evt || {};
evt.currentTarget = this;
evt.type = eventType;