mdbprivate is.... private.
mdbodbc.h has no reason to be public: People who want to use the plugin
should use the public odbc.h headers. And having this private will permit
hdbc cleanup.
According to the spec, pcbValue is designated as an output only variable, so there is no need to validate any incoming values.
Some packages do not initialize this variable before passing it into the function call; this will randomly result in an improperly thrown error.
Removed the input validation.
That missing break is not just a memory leak:
It results in incorrect call to mdb_unicode2ascii for binary data!
I suspect that is what is causing segfault on some db as repported on
https://github.com/brianb/mdbtools/issues/19
According to the spec, pcbValue is designated as an output only variable, so there is no need to validate any incoming values.
Some packages do not initialize this variable before passing it into the function call; this will randomly result in an improperly thrown error.
Removed the input validation.
__attribute__ does not exist in Visual Studio. Therefore replaced wherever it appeared with a macro:
Redefines MDB_DEPRECATED to support Visual Studio
Define a Constructor MACRO so that __attribute__((constructor/destructor)) behavior is achieved in Visual Studio.
Just using generate_table_schema through mdb_print_schema deletes the purpose of a very good tool. generate_table_schemas is a rewrite of generate_table_schema but sends the data to a char* instead of FILE*. There is NO fmemopen() or similar in Visual Studio, so there is NO way to access memory through a FILE* except for first writing to the disk and then reading from the disk in memory.
I cannot suggest how to handle the case when td == 0 for the dates. The databases I work with often have just 00:00:00 in the DateTime column which is not consistent with the rest of the column either, but I have to deal with it somehow.
Leaving void* where char* is needed as a function parameter returns a compilation error in Visual Studio.
Supported modes are:
- strip (don't export)
- raw (compatibility)
- octal (export as \ooo)
Note that gmdb2 dialog where updated, but not the code. Many fixes to do
there first :/
We had to support -export-symbols-regex anways
And map file did not really support versions but only list which symbol
to export. So this is more simple.
Nirgal Vourgère